David served in the House of Commons for 55 years, 10 months.
Biography source
UK Parliament Members API
FAQs
How long was Sir David Knox an MP?
Sir David Knox served in the House of Commons for 55 years, 10 months. Source