John served in the House of Commons for 38 years, 11 months.
Biography source
UK Parliament Members API
FAQs
How long was Mr John McAllion an MP?
Mr John McAllion served in the House of Commons for 38 years, 11 months. Source